Skip to content

feat(video): full screen gesture - #17680

Merged
alperozturk96 merged 6 commits into
masterfrom
feat/full-screen-media-player
Sep 22, 2026
Merged

feat(video): full screen gesture#17680
alperozturk96 merged 6 commits into
masterfrom
feat/full-screen-media-player

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Removes not-active codes
  • Moves logic to the extensions and unifies the toggle logic

Test

When user taps the video app should enter the full-screen mode and all controls and system bar must be not visible and user should be able to revert with another tap.

@alperozturk96 alperozturk96 linked an issue Sep 21, 2026 that may be closed by this pull request
Player controls and media title never disappear #17676
Closed
4 tasks
@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 6c34f12
Version 17680
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17680-IT-master-11-28

@codecov

codecov Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...com/nextcloud/utils/extensions/WindowExtensions.kt 0.00% 20 Missing ⚠️
...loud/android/ui/preview/PreviewPlaybackFragment.kt 0.00% 16 Missing ⚠️
...wncloud/android/ui/preview/PreviewImageActivity.kt 0.00% 3 Missing ⚠️
...a/com/nextcloud/client/player/ui/PlayerActivity.kt 0.00% 1 Missing ⚠️
...wncloud/android/ui/preview/PreviewImageFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 21, 2026
@alperozturk96

alperozturk96 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@alperozturk96
feat(video): full screen gesture
938e541 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better variable names
04e75fb 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove unused code for entering and exiting full-screen
7539745 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use extension and remove unused extension
44506e2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/full-screen-media-player branch from 41c8ee6 to 44506e2 Compare September 21, 2026 14:55
@alperozturk96 alperozturk96 mentioned this pull request Sep 21, 2026
Closed
4 tasks
@alperozturk96
remove imports that not used
856a269 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
daniele-verducci
daniele-verducci approved these changes Sep 22, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, works well!

A further improvement could be to hide the system buttons when going fullscreen, as right now they instead appear when going fullscreen:

Screen_recording_20260922_114941.webm

This is only on devices with the 2 or 3-buttons navigation, that's no more the default, so I don't know if it makes sense spend time on fixing this...

@alperozturk96
hide nav bar as well
6c34f12 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
daniele-verducci
daniele-verducci approved these changes Sep 22, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfetto!!!

@alperozturk96
alperozturk96 merged commit 2c6558f into master Sep 22, 2026
22 of 23 checks passed
@alperozturk96
alperozturk96 deleted the feat/full-screen-media-player branch September 22, 2026 10:10
@backportbot backportbot Bot mentioned this pull request Sep 22, 2026
Merged
@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1818
Total360360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.1

Development

Successfully merging this pull request may close these issues.

Player controls and media title never disappear

2 participants

@alperozturk96 @daniele-verducci