Conversation
Nextcloud maintains the three most recent majors, but detect-versions.php selected every version inside the 12-month support window. With a 4-month cadence those overlap for about ten days after each release, so 35, 34, 33 and 32 were all listed as maintained. build-index.php then derived the section role from the loop index, which only defines 0..3, so the fourth version collided with the "last supported stable" role and the note was rendered twice, on 33 and on 32. Roles are now named constants assigned by position (first, last, middle) instead of arithmetic on the index, so a longer list cannot collide. verify-index.php rejects a duplicated or missing status note. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Thu, 17 Sep 2026 14:02:16 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index on docs.nextcloud.com labelled both 33 and 32 "This documents the last supported stable version of Nextcloud", visible on the page deployed by #15631.
Two things caused that.
detect_versions()selected every version inside the 12-month support window, and with a 4-month release cadence four versions sit inside that window for the ~10 days between a release and the oldest one's end of life (35 released 2026-09-15, 32 EOL 2026-09-26).build-index.phpthen derived the section role from the loop index:generate_section()only defines roles 0 to 3, so with four entries index 2 got$idx + 1= 3 and index 3 got 3 from the last-element rule. Both render the same sentence. At five entries the role falls through to an empty note and the section silently loses its status line.The supported set is now capped at
MAINTAINED_MAJORS = 3indetect-versions.php, matching the maintenance schedule, and exposed assupportedsobuild-index.phpconsumes it instead of recomputing the window itself. Roles became named constants assigned by position (first, last, anything between) so the collision cannot come back with a longer list.verify-index.phpnow fails on a duplicated or missing status note, whichgenerate-top-index.ymlalready runs on every PR.The
conf.pyversion_startfallback goes 32 → 33 becausebuild-docs.ymlfails the master build when that fallback disagrees withlowest_stable.Capping stops rebuilding
server/32nine days before 32's published EOL. The deploy step only adds version folders and never prunes, so the existing tree stays and the legacy block keeps linking it, PDFs and ePubs included.☑️ Resolves
No issue filed, spotted on the deployed page from #15631.
🖼️ Screenshots
✅ Checklist
codespellor similar and addressed any spelling issuesVerified by regenerating the index against the live release data and diffing it against the deployed one, the only change is 32 moving into the legacy block:
Both new assertions were checked against a deliberately broken index (
note "last supported stable" appears 2 times,4 maintained version sections but 3 status notes). The Sphinx manuals were not rebuilt, so theconf.pyversion picker change is reasoned about rather than observed:range(33, 35)yields 33 and 34, plus stable 35 and latest 36.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.