fix(files_external): align auth for DAV file transfers - #64291
Open
joshtrichards wants to merge 4 commits into
Open
fix(files_external): align auth for DAV file transfers#64291joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Two clients are used by the DAV Storage backend depending on the operation: Sabre for WebDAV ops and IClient (Guzzle) for streaming ops. This change centralizes authentication mapping so both clients receive the same effective auth mode. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim and
icewind1991
and removed request for
a team
September 14, 2026 03:02
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DAV external storage backend uses the Sabre client for WebDAV operations and Nextcloud’s generic HTTP client (IClient/Guzzle) for file streaming operations. When PR #4000 added
authTypehandling to the DAV backend, it applied only to the Sabre client.This change centralizes DAV authentication mapping for streamed GET and PUT requests, keeping authentication behavior consistent across both clients.
It also adds regression coverage for:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)