perf(core): allow versioned avatar URLs to be cached for 30 days - #64295
Draft
pringelmann wants to merge 1 commit into
Draft
perf(core): allow versioned avatar URLs to be cached for 30 days#64295pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avatar URLs can now carry a
?v=version. With it, the response is cached for 30 days instead of 1.The 1 day TTL means avatars get revalidated constantly, and a 304 here costs nearly as much as a 200 because the time goes into PHP bootstrap, not on sending the image itself. A big Talk call is a few hundred of those.
The version is bumped on avatar upload/removal, avatar scope changes, and enable/disable. Avatars that depend on who's asking (
v2-private) keep the 1 day window, since one URL serves different bytes to different viewers.?v=only widens the cache window, it never picks the image. A stale version still returns the current avatar.Nothing sends it yet, so this is a no-op alone. Talk and
@nextcloud/vuefollow separately.Trade-off
A bump only changes future URLs, it can't reach a cache that's already populated. So a deleted account's avatar can now linger in a browser for a month instead of a day. Same for one switched to
v2-private. 7 days also works if there are privacy concerns.Checklist
3. to review, feature component)stable32)AI (if applicable)