Skip to content

chore: upgrade to Vite+ 1.0 preview - #912

Draft
fengmk2 wants to merge 1 commit into
masterfrom
chore/viteplus-1-vitest-5
Draft

fengmk2 wants to merge 1 commit into
masterfrom
chore/viteplus-1-vitest-5

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 19, 2026

Copy link
Copy Markdown
Member

Vitest 5 changes mock defaults and removes the top-level bench API. This upgrade preserves the existing test behavior with the Vite+ 1.0 preview from voidzero-dev/vite-plus#2551.

The catalog pins 0.0.0-commit.81de5f37788bc4c0e46b0737c15e1be42f57403d and aligns Vitest and the coverage provider at 5.0.1. The .npmrc file selects the preview registry because 1.0.0 is not yet published.

The configuration keeps clearMocks: false and its compatibility comment to preserve mock call history. Each benchmark uses the test context's bench fixture and awaits .run(). The benchmark workflow uses pnpm exec vp test bench --run. The pack configuration keeps dependency subpath resolution enabled. The test setup, assertions, coverage selection, and public Node.js engine range stay unchanged.

@agentscanapp

agentscanapp Bot commented Sep 19, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitest/​coverage-v8@​4.1.11 ⏵ 5.0.19910079 +198 -1100
Updatedvitest@​4.1.11 ⏵ 5.0.198 +110079 +199 +1100

View full report

@pkg-pr-new

pkg-pr-new Bot commented Sep 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@912

commit: ee69d6e

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.23%. Comparing base (62fdb13) to head (ee69d6e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   94.24%   94.23%   -0.01%     
==========================================
  Files          10       10              
  Lines         747      746       -1     
  Branches      235      235              
==========================================
- Hits          704      703       -1     
  Misses         40       40              
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant