Skip to content

Remove unused resource parameter from getPermissionsFor #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NaderMohamed325 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused resource parameter from getPermissionsFor #1870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ba5a9b
Remove unused resource parameter from getPermissionsFor
Jul 28, 2026
9930190
Potential fix for pull request finding
NaderMohamed325 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/header.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ export async function addPermissions (req, res, next) {
const ldp = req.app.locals.ldp
const resource = ldp.resourceMapper.resolveUrl(req.hostname, req.path)
let [publicPerms, userPerms] = await Promise.all([
getPermissionsFor(acl, null, req),
getPermissionsFor(acl, session.userId, req)
getPermissionsFor(acl, null),
getPermissionsFor(acl, session.userId)
])
if (resource.endsWith('.acl') && userPerms === '' && await ldp.isOwner(session.userId, req.hostname)) userPerms = 'control'
debug.ACL(`Permissions on ${resource} for ${session.userId || '(none)'}: ${userPerms}`)
Expand All @@ -130,8 +130,8 @@ export async function addPermissions (req, res, next) {
next()
}

// Gets the permissions string for the given user and resource
async function getPermissionsFor (acl, user, req) {
// Gets the permissions string for the given user
async function getPermissionsFor (acl, user) {
const accesses = MODES.map(mode => acl.can(user, mode))
const allowed = await Promise.all(accesses)
return PERMISSIONS.filter((mode, i) => allowed[i]).join(' ')
Expand Down