Skip to content

fix: correct lint:eslint:fix script - #1131

Merged
targos merged 1 commit into
nodejs:mainfrom
MikeMcC399:fix/eslint-fix
Aug 21, 2026
Merged

fix: correct lint:eslint:fix script#1131
targos merged 1 commit into
nodejs:mainfrom
MikeMcC399:fix/eslint-fix

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

Attempting to execute the script lint:eslint:fix fails:

$ npm run lint:eslint:fix

> citgm@10.0.2 lint:eslint:fix
> npm run eslint -- --fix

npm error Missing script: "eslint"
npm error
npm error Did you mean this?
npm error   npm run lint # run the "lint" package script
npm error
npm error To see a list of scripts, run:
npm error   npm run
npm error A complete log of this run can be found in: /home/mike/.npm/_logs/2026-08-21T13_16_39_901Z-debug-0.log

Change

Update the script lint:eslint:fix definition to delegate to lint:eslint

Checklist
  • npm test passes
  • contribution guidelines followed
    here
$ npm run lint:eslint:fix

> citgm@10.0.2 lint:eslint:fix
> npm run lint:eslint -- --fix


> citgm@10.0.2 lint:eslint
> eslint --cache --fix

cc: @targos

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why is it draft?

@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (d4cf2e2) to head (f004670).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 21, 2026 13:30
@targos
targos merged commit eef880d into nodejs:main Aug 21, 2026
11 checks passed
@MikeMcC399
MikeMcC399 deleted the fix/eslint-fix branch August 21, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants