perf(core): overlap file reads within ast generator chunks - #1094
Open
btea wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
=======================================
Coverage 90.60% 90.60%
=======================================
Files 217 217
Lines 20813 20818 +5
Branches 1974 1975 +1
=======================================
+ Hits 18858 18863 +5
Misses 1948 1948
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.37 MB | 9.37 MB | -1.49 KB (-0.0%) |
Performance estimate (single CI run)
- Generation time: 4.4% faster (21.72 s → 20.76 s)
- Peak memory: 14.0% higher (1.88 GB → 2.15 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 6.9% slower (126.55 s → 135.25 s)
- Peak memory: 5.2% lower (5.39 GB → 5.11 GB)
Member
|
Can you provide benchmarks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
processChunk awaited one file read at a time, so I/O within a chunk was fully serialized. Reads now run concurrently via Promise.all, bounded by the chunk size; parsing remains sequential.
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.