refactor(react): extract @doc-kittens/react package - #959
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview The former Tests, ESLint browser paths, and Reviewed by Cursor Bugbot for commit f8d1d66. Bugbot is set up for automated code reviews on this repo. Configure here. |
316965a to
fbba838
Compare
@avivkeller ensure documentation is up to date! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 88.94% 85.64% -3.31%
==========================================
Files 197 212 +15
Lines 18106 18887 +781
Branches 1664 1668 +4
==========================================
+ Hits 16105 16175 +70
- Misses 1994 2705 +711
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 45 out of 103 changed files in this pull request and generated no new comments.
Suppressed comments (2)
packages/react/src/sitemap/utils/createPageSitemapEntry.mjs:7
- The function accepts a
lastmodargument but the JSDoc doesn’t document it, which makes the generated typings/docs incomplete and misleading.
packages/react/package.json:4 packages/react/package.jsondeclares version0.0.0, butpackage-lock.jsonrecords this workspace as1.0.0(see package-lock.json:11385). This inconsistency can cause confusing installs/publishes; the lockfile should reflect the package.json version.
"version": "0.0.0",
fbba838 to
f8d1d66
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8d1d66. Configure here.
| -t legacy-json \ | ||
| -t llms-txt \ | ||
| -t web \ | ||
| -t html \ |
There was a problem hiding this comment.
Beta config still uses web key
High Severity
beta/doc-kit.config.mjs still configures the generator under web, but the generator name is now html and all lookups use getConfig('html'). The Vercel build passes -t html with this file, so the custom remoteConfigUrl never merges into the active config and the beta site keeps the default Node.js banner endpoint.
Reviewed by Cursor Bugbot for commit f8d1d66. Configure here.
| "./orama-db": "./src/orama-db/index.mjs", | ||
| "./sitemap": "./src/sitemap/index.mjs", | ||
| "./package.json": "./package.json" | ||
| }, |
There was a problem hiding this comment.
Vite bundler export missing
Medium Severity
@doc-kittens/react only exports the generator entrypoints, with no path for createViteBundler. Previously consumers could import the adapter through @node-core/doc-kit's src/* export; after the move that public customization path is gone and deep imports are blocked by the exports map.
Reviewed by Cursor Bugbot for commit f8d1d66. Configure here.
|


The React/JSX-based generators (
html, renamed fromweb),jsx-ast,llms-txt,sitemap, andorama-dbhave moved into the new@doc-kittens/reactpackage, and are loaded via import specifiers such as@doc-kittens/react/html.To avoid breaking existing CLIs, the
htmlgenerator can be referred to by thewebspecifier.