Skip to content

refactor(legacy): extract @doc-kittens/legacy package - #960

Open
avivkeller wants to merge 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten
Open

refactor(legacy): extract @doc-kittens/legacy package#960
avivkeller wants to merge 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 30, 2026

Copy link
Copy Markdown
Member

The legacy-format generators (legacy-html, legacy-html-all, legacy-json, and legacy-json-all) have moved into the new @doc-kittens/legacy package, and are loaded via import specifiers such as @doc-kittens/legacy/legacy-html.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 1, 2026 3:27pm

Request Review

@avivkeller
avivkeller marked this pull request as ready for review July 30, 2026 21:34
@avivkeller
avivkeller requested a review from a team as a code owner July 30, 2026 21:34
Copilot AI review requested due to automatic review settings July 30, 2026 21:34
@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Breaking for anyone importing legacy generators from @node-core/doc-kit/legacy-*; CLI shorthands are preserved but the monorepo must resolve the new workspace package correctly at build/runtime.

Overview
Legacy HTML/JSON generators are split out of @node-core/doc-kit into a new @doc-kittens/legacy workspace package, with the four generators exposed as @doc-kittens/legacy/legacy-html, legacy-html-all, legacy-json, and legacy-json-all.

@node-core/doc-kit no longer exports those generator entry points from package.json; the CLI/config shorthand names (legacy-html, etc.) still work because publicGenerators now resolves them to the new package. Generator dependsOn links between legacy-html-all/json-all and their base generators point at @doc-kittens/legacy/... instead of core.

Implementation code is relocated unchanged in behavior, with relative imports swapped for @node-core/doc-kit/... utilities and types. legacyToJSON moves from core utils/generators.mjs into packages/legacy/src/utils/ (tests move with it). Core drops the legacyToJSON tests from generators.test.mjs; parseList’s JSDoc loosens the section type so core no longer references legacy-json types.

Tooling updates: ESLint browser globals apply to packages/legacy/src/legacy-html/assets/*.js, and the changeset marks @doc-kittens/legacy major and @node-core/doc-kit minor for consumers who imported legacy paths from core.

Reviewed by Cursor Bugbot for commit d75c211. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 1, 2026 10:36
@ovflowd
ovflowd force-pushed the refactor/legacy-kitten branch from 9d9d060 to 0f93e3d Compare August 1, 2026 10:36
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.54%. Comparing base (f8d1d66) to head (d75c211).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           refactor/react-kitten     #960      +/-   ##
=========================================================
- Coverage                  85.64%   84.54%   -1.10%     
=========================================================
  Files                        212      215       +3     
  Lines                      18887    19148     +261     
  Branches                    1668     1670       +2     
=========================================================
+ Hits                       16175    16188      +13     
- Misses                      2705     2953     +248     
  Partials                       7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd

ovflowd commented Aug 1, 2026

Copy link
Copy Markdown
Member

The legacy-format generators (legacy-html, legacy-html-all, legacy-json, and legacy-json-all) have moved into the new @doc-kittens/legacy package, and are loaded via import specifiers such as @doc-kittens/legacy/legacy-html.

nit: can we name it @doc-kittens/legacy-nodejs? (also fine w/ current)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0f93e3d. Configure here.

Comment thread eslint.config.mjs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 45 changed files in this pull request and generated 1 comment.

Comment on lines +2 to +3
'@doc-kittens/legacy': major
'@node-core/doc-kit': minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants