Skip to content

fix: sync URL hash when following same-page search hits #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 2 commits into from
Aug 1, 2026
+16 −13
Merged

fix: sync URL hash when following same-page search hits #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dcb2e1
fix(web): sync URL hash when following same-page search hits
btea Jul 31, 2026
7f459f7
fix: update
btea Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-donuts-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@node-core/doc-kit': patch
---

Sync the URL hash when following same-page search hits
24 changes: 11 additions & 13 deletions packages/core/src/generators/web/ui/components/SearchBox/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const followSearchHit = event => {
return;
}

const target = new URL(event.currentTarget.href);
const { href } = event.currentTarget;

event.preventDefault();

Expand All @@ -30,18 +30,16 @@ const followSearchHit = event => {
new KeyboardEvent('keydown', { key: 'Escape', bubbles: true })
);

requestAnimationFrame(() => {
if (target.pathname !== window.location.pathname) {
window.location.href = target.href;
return;
}

requestAnimationFrame(() =>
document
.getElementById(decodeURIComponent(target.hash.slice(1)))
?.scrollIntoView()
);
});
// A plain `location.href` assignment covers both cases: same-page hits
// become a native fragment navigation (hash, scroll and history entry
// included), cross-page hits simply load the target page. The nested
// `requestAnimationFrame` waits for the modal to actually close —
// navigating while it is still open suppresses the fragment scroll.
requestAnimationFrame(() =>
requestAnimationFrame(() => {
window.location.href = href;
})
);
};

/**
Expand Down
Loading