Skip to content

Fix duplicate ci run check - #1188

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/fix-duplicate-ci-run-check
Sep 9, 2026
Merged

Fix duplicate ci run check#1188
aduh95 merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/fix-duplicate-ci-run-check

Conversation

@jasnell

@jasnell jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member

It appears there was a bug in the duplicate run checking. As evidenced here nodejs/node#65920 (comment) ... where there was a prior CI run that was detected but ignored, causing a new run to be started.

@jasnell
jasnell requested review from aduh95 and panva September 9, 2026 16:46
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.86%. Comparing base (92bf51c) to head (e23a497).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   57.81%   57.86%   +0.05%     
==========================================
  Files          53       53              
  Lines       10396    10397       +1     
==========================================
+ Hits         6010     6016       +6     
+ Misses       4386     4381       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

It appears there was a bug in the duplicate run checking.
@jasnell
jasnell force-pushed the jasnell/fix-duplicate-ci-run-check branch from 656dffd to e23a497 Compare September 9, 2026 16:51
@aduh95
aduh95 merged commit 949fb8e into nodejs:main Sep 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants