Skip to content

doc: create ai-guidelines and include to CONTRIBUTING - #62105

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:add-ai-guidelines
Open

doc: create ai-guidelines and include to CONTRIBUTING#62105
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:add-ai-guidelines

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Mar 4, 2026

Copy link
Copy Markdown
Member

As discussed in today's TSC meeting.

cc: @nodejs/tsc @BridgeAR

@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 4, 2026
joyeecheung
joyeecheung reviewed Mar 5, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
@joyeecheung

joyeecheung commented Mar 5, 2026

Copy link
Copy Markdown
Member

There may be some ideas we can borrow from https://llvm.org/docs/AIToolPolicy.html - for example "good first issue" should not be picked up by AI is a good one.

Aditi-1400
Aditi-1400 reviewed Mar 5, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
@RafaelGSS

RafaelGSS commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

There may be some ideas we can borrow from https://llvm.org/docs/AIToolPolicy.html - for example "good first issue" should not be picked up by AI is a good one.

I took inspiration from https://github.com/zulip/zulip/blob/main/CONTRIBUTING.md#ai-use-policy-and-guidelines

Renegade334
Renegade334 reviewed Mar 5, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
mcollina
mcollina requested changes Mar 5, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
* **Verify accuracy** of any LLM-generated content before including it in a
PR description or comment.
* **Complete pull request templates fully** rather than replacing them with
LLM-generated summaries.

@mcollina mcollina Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a template? I thought those are for issues, not PRs.

@legendecas legendecas Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly a template: https://github.com/nodejs/node/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1

@MikeMcC399 MikeMcC399 Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to fulfil the instructions "Complete pull request templates fully" based on the contents of https://github.com/nodejs/node/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1 so it looks like this sentence needs to be removed.

tniessen
tniessen reviewed Mar 6, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
aduh95
aduh95 reviewed Mar 9, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
MikeMcC399
MikeMcC399 reviewed Mar 9, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
MikeMcC399
MikeMcC399 reviewed Mar 9, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
MikeMcC399

This comment was marked as resolved.

Sign in to view

@RafaelGSS
RafaelGSS requested a review from mcollina March 13, 2026 16:39
@RafaelGSS RafaelGSS added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 13, 2026
gurgunday
gurgunday approved these changes Mar 13, 2026
View reviewed changes

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2026
@joyeecheung joyeecheung mentioned this pull request Mar 17, 2026
Open
indutny
indutny previously requested changes Mar 17, 2026
View reviewed changes

@indutny indutny left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be against this contribution policy update. While many different opinions exist on the licensing terms of the code produced by LLMs, my opinion is that the generated code isn't explicitly licensed and attributed to the original authors so it cannot be considered open source regardless of the used prompt.

@joyeecheung joyeecheung added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 17, 2026
@joyeecheung joyeecheung mentioned this pull request Mar 17, 2026
Closed
mcollina
mcollina reviewed Mar 17, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment on lines +56 to +59
* **Verify accuracy** of any LLM-generated content before including it in a
PR description or comment.
* **Complete pull request templates fully** rather than replacing them with
LLM-generated summaries.

@mcollina mcollina Mar 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Verify accuracy** of any LLM-generated content before including it in a
PR description or comment.
* **Complete pull request templates fully** rather than replacing them with
LLM-generated summaries.
* **Verify accuracy** of any LLM-generated content before including it in a
PR description or comment.

@joyeecheung

joyeecheung commented Mar 17, 2026

Copy link
Copy Markdown
Member

In #61478 (comment) , regarding the usage of Claude Code, @mcollina suggested:

As it seems that you have a different position on this issue, I will bring this to the attention of the @nodejs/tsc for an official vote. On a side note, I would also officially summon the topic at the next OpenJS board meeting.

I added it to the TSC agenda tomorrow for awareness/context collection before moving to a proper vote. @indutny sorry about the short notice since this is just one day ahead of the meeting, but if you'd like to join the meeting to present your points please let us know.

mcollina
mcollina approved these changes Mar 17, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a sentence removed

@indutny

indutny commented Mar 17, 2026

Copy link
Copy Markdown
Member

@joyeecheung thanks for considering me for this! I'd be happy to join if the time isn't in conflict with my work meetings tomorrow. Could you send me an invite, please?

@mcollina

mcollina commented Mar 17, 2026

Copy link
Copy Markdown
Member

nodejs/TSC#1830 this is the issue. It might be reschedueld to the next meeting if there is low attedance given the timezone.

I think we can schedule the discussion for April 1st which will be in the morning PT so a lot of people can join, and I would table the vote for that session. I would try to get an answer from the Board by then.

@mcollina mcollina mentioned this pull request Mar 17, 2026
Open
@openjs-meetings-bot openjs-meetings-bot Bot mentioned this pull request May 14, 2026
Closed
@mcollina

mcollina commented May 16, 2026

Copy link
Copy Markdown
Member

@indutny @bengl ping

@openjs-meetings-bot openjs-meetings-bot Bot mentioned this pull request May 21, 2026
Closed
@mcollina

mcollina commented May 27, 2026

Copy link
Copy Markdown
Member

Discussed at the last @nodejs/tsc.
After 2 weeks or more without a response, we consider the objection dismissed.

@openjs-meetings-bot openjs-meetings-bot Bot mentioned this pull request May 28, 2026
Closed
@RafaelGSS
RafaelGSS force-pushed the add-ai-guidelines branch from 84a3b2d to b696334 Compare May 28, 2026 23:42
@RafaelGSS @BethGriggs
@Aditi-1400 @joyeecheung @tniessen @aduh95 @MikeMcC399 @efekrskl @jasnell @trivikr
doc: create ai-guidelines and include to CONTRIBUTING
2c97efd 
Co-authored-by: Beth Griggs <bethanyngriggs@gmail.com>
Co-authored-by: Aditi <62544124+Aditi-1400@users.noreply.github.com>
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: Efe <dogukankrskl@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS force-pushed the add-ai-guidelines branch from b696334 to 2c97efd Compare May 28, 2026 23:42
@RafaelGSS

RafaelGSS commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have squashed the commits and solved the linting issue. Nothing has changed. PTAL.

mcollina
mcollina approved these changes May 29, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
RafaelGSS dismissed indutny’s stale review May 29, 2026 18:23

Per Node.js guidelines, after 2 weeks or more without a response, we consider the objection dismissed.

@RafaelGSS RafaelGSS removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels May 29, 2026
joyeecheung
joyeecheung reviewed May 29, 2026
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording tightening and adding references..

Also I believe we should reference the large PR policy added by #62829 in this document, though not exactly sure where?

Comment thread doc/contributing/ai-guidelines.md
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
Comment thread doc/contributing/ai-guidelines.md Outdated
joyeecheung
joyeecheung reviewed Jun 3, 2026
View reviewed changes
Comment thread doc/contributing/ai-guidelines.md
@MikeMcC399 MikeMcC399 mentioned this pull request Jun 12, 2026
Closed
12 tasks
@jasnell jasnell mentioned this pull request Jul 7, 2026
Closed
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jul 18, 2026
Open
@RafaelGSS
RafaelGSS requested a review from joyeecheung August 5, 2026 18:55
@RafaelGSS
fixup! doc: create ai-guidelines and include to CONTRIBUTING
2d77889 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@ovflowd

ovflowd commented Aug 6, 2026

Copy link
Copy Markdown
Member

Linting seems to be failing, that said it does look like this PR is ready?

joyeecheung
joyeecheung approved these changes Aug 6, 2026
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one final wording suggestions, thanks!

Comment thread doc/contributing/ai-guidelines.md
Comment on lines +67 to +68
the correctness of new tests against the expected behavior of the feature
being tested, independently of the feature's implementation.

@joyeecheung joyeecheung Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the correctness of new tests against the expected behavior of the feature
being tested, independently of the feature's implementation.
the correctness of new tests against the intended behavior of the feature
being tested, independently of how the implementation happens to behave.

I was just reading a post by a maintainer of another prominent OSS project today who was frustrated by a 10K+ LOC AI-generated PR and saw some wording about this behavior that we can borrow - I also saw this behavior when reviewing #63115 which exposed internalModuleStat by mistake and then went on to make even more mistakes by ensuring the internal API is publicly usable 🤦🏻‍♀️, seems like a common issue of AI-generated big patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@MikeMcC399 MikeMcC399 MikeMcC399 left review comments
@bengl bengl bengl left review comments
@avivkeller avivkeller avivkeller left review comments
@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood left review comments
@aduh95 aduh95 aduh95 left review comments
@ChALkeR ChALkeR ChALkeR left review comments
@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments
@ljharb ljharb ljharb left review comments
@bnb bnb bnb left review comments
@Renegade334 Renegade334 Renegade334 left review comments
@targos targos targos left review comments
@jasnell jasnell jasnell approved these changes
@ovflowd ovflowd ovflowd approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@daeyeon daeyeon daeyeon approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@MoLow MoLow MoLow approved these changes
@legendecas legendecas legendecas approved these changes
@lpinca lpinca lpinca approved these changes
@ronag ronag ronag approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@panva panva panva approved these changes
@trivikr trivikr trivikr approved these changes
@gurgunday gurgunday gurgunday approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@Aditi-1400 Aditi-1400 Aditi-1400 approved these changes
@mcollina mcollina mcollina approved these changes
+3 more reviewers
@italojs italojs italojs left review comments
@efekrskl efekrskl efekrskl left review comments
@indutny indutny indutny left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.