Skip to content

repl: add benchmarks - #64590

Closed
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:repl-benchmarks
Closed

repl: add benchmarks#64590
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:repl-benchmarks

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 19, 2026

Copy link
Copy Markdown
Member

Adds benchmarks for the REPL including:

  • Evaluation
  • Completion
  • Creation
  • Line Process
  • Context Resetting

@avivkeller
repl: add benchmarks
2e48bb6 
Signed-off-by: avivkeller <me@aviv.sh>
@nodejs-github-bot

nodejs-github-bot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Jul 19, 2026
@codecov

codecov Bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (4f844f4) to head (b4cff78).
⚠️ Report is 427 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64590      +/-   ##
==========================================
+ Coverage   90.13%   90.30%   +0.16%     
==========================================
  Files         741      759      +18     
  Lines      241976   247644    +5668     
  Branches    45543    46693    +1150     
==========================================
+ Hits       218116   223637    +5521     
- Misses      15379    15472      +93     
- Partials     8481     8535      +54

see 203 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

avivkeller commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

cc @nodejs/repl

@avivkeller avivkeller added the review wanted PRs that need reviews. label Aug 15, 2026
@avivkeller

avivkeller commented Aug 15, 2026

Copy link
Copy Markdown
Member Author

Bump!

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75884/

@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75888/

avivkeller added a commit that referenced this pull request Aug 17, 2026
@avivkeller
repl: add benchmarks
89310c7 
Signed-off-by: avivkeller <me@aviv.sh>
PR-URL: #64590
Reviewed-By: James M Snell <jasnell@gmail.com>
@avivkeller

avivkeller commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

Landed in 89310c7

@avivkeller avivkeller closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avivkeller @nodejs-github-bot @jasnell