url: preserve property order in URLPattern results #64735
Draft
Archkon wants to merge 2 commits into
Draft
Conversation
Reorder the URLPatternResult and URLPatternComponentResult dictionary templates, together with their value arrays, to follow the lexicographical member order required by WebIDL. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
nodejs-github-bot
added
c++
Archkon
marked this pull request as draft
July 25, 2026 10:38
Use each compiled component's group name list when materializing URLPattern capture groups instead of iterating an unordered map. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
anonrig
reviewed
Jul 26, 2026
| auto isolate = env->isolate(); | ||
| auto context = env->context(); | ||
| LocalVector<Name> group_names(isolate); | ||
| LocalVector<Name> js_group_names(isolate); |
Member
There was a problem hiding this comment.
please keep the change at minimum and avoid unnecessary changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64734