crypto: fix CA trust block parsing #64753
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Archkon
marked this pull request as draft
July 26, 2026 05:51
nodejs-github-bot
added
c++
Contributor
Author
|
ping @bnoordhuis |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64753 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.03%
==========================================
Files 744 744
Lines 242517 242517
Branches 45688 45696 +8
==========================================
- Hits 218642 218583 -59
- Misses 15358 15434 +76
+ Partials 8517 8500 -17 🚀 New features to boost your workflow:
|
Treat blank lines, rather than comments, as trust block boundaries when parsing certdata.txt. This ensures trust attributes following CKA_NSS_SERVER_DISTRUST_AFTER comments are still processed. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Archkon
changed the title
Archkon
marked this pull request as ready for review
July 26, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64752