ffi: remove dead null check in callback arguments - #64998
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
the
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64998 +/- ##
==========================================
+ Coverage 90.12% 90.14% +0.02%
==========================================
Files 752 752
Lines 251824 251821 -3
Branches 47346 47370 +24
==========================================
+ Hits 226950 227011 +61
+ Misses 16224 16164 -60
+ Partials 8650 8646 -4
🚀 New features to boost your workflow:
|
trivikr
force-pushed
the
ffi-invoke-callback-dead-branch
branch
from
August 9, 2026 23:21
c49d330 to
95c8bec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
ShogunPanda
approved these changes
Aug 17, 2026
trivikr
added
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64998 ✔ Done loading data for nodejs/node/pull/64998 ----------------------------------- PR info ------------------------------------ Title ffi: remove dead null check in callback arguments (#64998) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch trivikr:ffi-invoke-callback-dead-branch -> nodejs:main Labels c++, needs-ci, ffi Commits 1 - ffi: remove dead null check in callback arguments Committers 1 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64998 Reviewed-By: Paolo Insogna <paolo@cowtech.it> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64998 Reviewed-By: Paolo Insogna <paolo@cowtech.it> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Aug 2026 03:56:29 GMT ✔ Approvals: 1 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/64998#pullrequestreview-4949369957 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-11T04:26:08Z: https://ci.nodejs.org/job/node-test-pull-request/75762/ - Querying data for job/node-test-pull-request/75762/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32045336475 |
trivikr
removed
the
commit-queue-failed
InvokeCallback tested `args[i] == nullptr` and mapped the argument to JS `null`. `args` is libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argument, so the slot pointers are never null and the branch never ran. The check also read as a guarantee the code does not provide: a NULL pointer argument surfaces as the BigInt `0n`, because ToJSArgument converts `ffi_type_pointer` values with BigInt::NewFromUnsigned. Drop the branch rather than reimplementing it in ToJSArgument, which would change behavior by making pointer parameters arrive as either a BigInt or `null`. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5 PR-URL: nodejs#64998 Reviewed-By: Paolo Insogna <paolo@cowtech.it>
trivikr
force-pushed
the
ffi-invoke-callback-dead-branch
branch
from
August 17, 2026 16:39
95c8bec to
d95dba2
Compare
Member
Author
|
Landed in d95dba2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvokeCallback tested
args[i] == nullptrand mapped the argument to JSnull.argsis libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argument, so the slot pointers are never null and the branch never ran.The check also read as a guarantee the code does not provide: a NULL pointer argument surfaces as the BigInt
0n, because ToJSArgument convertsffi_type_pointervalues with BigInt::NewFromUnsigned. Drop the branch rather than reimplementing it in ToJSArgument, which would change behavior by making pointer parameters arrive as either a BigInt ornull.Assisted-by: claude:opus-5