Skip to content

diagnostics_channel: validate before channel activation #65313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

diagnostics_channel: validate before channel activation #65313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/diagnostics_channel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ class Channel {
}

subscribe(subscription) {
validateFunction(subscription, 'subscription');
markActive(this);
this.subscribe(subscription);
}
Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-diagnostics-channel-object-channel-pub-sub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ assert.ok(!channel.unsubscribe(subscriber));
assert.throws(() => {
channel.subscribe(null);
}, { code: 'ERR_INVALID_ARG_TYPE' });
assert.ok(!channel.hasSubscribers);
assert.ok(!dc.hasSubscribers('test'));
2 changes: 2 additions & 0 deletions test/parallel/test-diagnostics-channel-pub-sub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ assert.ok(!dc.unsubscribe(name, subscriber));
assert.throws(() => {
dc.subscribe(name, null);
}, { code: 'ERR_INVALID_ARG_TYPE' });
assert.ok(!channel.hasSubscribers);
assert.ok(!dc.hasSubscribers(name));

// Reaching zero subscribers should not delete from the channels map as there
// will be no more weakref to incRef if another subscribe happens while the
Expand Down
Loading