Skip to content

test: keep WPT backend checks alive - #65320

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-wpt-backends-lifetime
Open

test: keep WPT backend checks alive#65320
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-wpt-backends-lifetime

Conversation

@panva

@panva panva commented Aug 16, 2026

Copy link
Copy Markdown
Member

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 16, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 16, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65320      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      251569   251569              
  Branches    47264    47273       +9     
==========================================
- Hits       226724   226712      -12     
- Misses      16188    16213      +25     
+ Partials     8657     8644      -13     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva

panva commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants