Skip to content

permission: guard UDP handle adoption - #65358

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-permission-udp-handle-receive
Open

permission: guard UDP handle adoption#65358
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-permission-udp-handle-receive

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

Ensures IPC (parent -> child communication) passes by permission model checks.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Aug 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Aug 17, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS force-pushed the fix-permission-udp-handle-receive branch from 49658da to ec5672e Compare August 17, 2026 22:14
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (45d6d31) to head (ec5672e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/udp_wrap.cc 66.66% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65358      +/-   ##
==========================================
- Coverage   90.13%   90.13%   -0.01%     
==========================================
  Files         752      752              
  Lines      251872   251892      +20     
  Branches    47359    47371      +12     
==========================================
+ Hits       227033   227045      +12     
- Misses      16167    16172       +5     
- Partials     8672     8675       +3     
Files with missing lines Coverage Δ
src/udp_wrap.h 100.00% <ø> (ø)
src/udp_wrap.cc 78.54% <66.66%> (-0.25%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants