test: add Headers coverage and benchmark - #65365
Open
anonrig wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node can track the API after the implementation change lands in undici. Refs: nodejs/undici#5699 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 01:59
3ea8120 to
eb22154
Compare
anonrig
changed the title
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 02:06
eb22154 to
2edacb0
Compare
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
previously requested changes
Aug 18, 2026
jasnell
left a comment
jasnell
left a comment
Member
There was a problem hiding this comment.
AI agents are not permitted to use the Signed-off-by
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18%
==========================================
Files 751 752 +1
Lines 249956 251884 +1928
Branches 47204 47379 +175
==========================================
+ Hits 225745 227054 +1309
- Misses 15612 16147 +535
- Partials 8599 8683 +84 🚀 New features to boost your workflow:
|
mcollina
approved these changes
Aug 18, 2026
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
Code LGTM. Commit metadata needs fixing.
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 12:49
2edacb0 to
0225f7b
Compare
Member
Author
|
Addressed the review feedback:
|
gurgunday
approved these changes
Aug 18, 2026
anonrig
added
author ready
mertcanaltin
approved these changes
Aug 18, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
anonrig
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Node-side coverage for the WHATWG
HeadersAPI and afetch/headersbenchmark.These tests are not from WPT. They cover constructor init, get/set/append/delete,
set-cookie/getSetCookie(), iteration (including mutation during iteration), validation, brand checks, andutil.inspect.The implementation change lives in undici:
Refs: nodejs/undici#5699