Skip to content

test: simplify worker heap profile rejection assertion - #65372

Open
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-worker-heap-profile.js
Open

test: simplify worker heap profile rejection assertion#65372
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-worker-heap-profile.js

Conversation

@HoonDongKang

Copy link
Copy Markdown
Contributor

Replaced try/catch with assert.rejects in the duplicate worker.startHeapProfile() call test for improved readability.

Refs:

Tests:

  • ./node test/parallel/test-worker-heap-profile.js
  • tools/test.py test/parallel/test-worker-heap-profile.js
[00:00|% 100|+   1|-   0]: Done                            

All tests passed.

Signed-off-by: HoonDongKang <d159123@naver.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (13fcd6f) to head (58d0ae6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65372      +/-   ##
==========================================
- Coverage   91.85%   90.14%   -1.72%     
==========================================
  Files         400      752     +352     
  Lines      178855   251884   +73029     
  Branches    27319    47360   +20041     
==========================================
+ Hits       164283   227050   +62767     
- Misses      14243    16170    +1927     
- Partials      329     8664    +8335     

see 486 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants