vfs: reject rename onto a non-empty directory - #65373
Open
dibenkobit wants to merge 1 commit into
Open
Conversation
MemoryProvider.renameSync() rejected directory/non-directory mismatches but never checked whether an existing directory destination was empty, so renaming a directory onto a non-empty one silently discarded the destination's contents. POSIX rename(2) requires the destination directory to be empty, and RealFSProvider already reports ENOTEMPTY, so the two providers Node ships disagreed with each other. Signed-off-by: Nikita Snetkov <lukyanish@gmail.com>
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX requires the destination of a directory rename to be an empty directory.
fs.renameSync()reportsENOTEMPTYbecause the OS enforces it, andRealFSProviderinherits that by delegating to the real filesystem.MemoryProviderhas no OS underneath, so it implements these rules itself — it already coversEISDIR,ENOTDIRandEINVAL, but not this one: it renamed over a non-empty directory and silently discarded its contents.Assisted-By: Claude Code (Claude Opus 5)