module: derive builtinModules from enabled builtin set - #65418
Merged
nodejs-github-bot merged 1 commit intoAug 29, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03
force-pushed
the
refactor/module-builtin-exposure
branch
from
August 20, 2026 08:31
614500e to
79ffed7
Compare
Contributor
Author
|
Follow-up: the focused test assumed that
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65418 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.02%
==========================================
Files 752 752
Lines 251870 252321 +451
Branches 47365 47441 +76
==========================================
+ Hits 227037 227404 +367
- Misses 16177 16216 +39
- Partials 8656 8701 +45
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Aug 21, 2026
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
i love this. drastically minimizes the chance the list will be wrong.
jsumners-nr
approved these changes
Aug 21, 2026
daeyeon
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
daeyeon
added
the
commit-queue
Collaborator
|
Landed in 7b0de5e |
nodejs-github-bot
removed
the
commit-queue
panva
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module.builtinModulesis expected to contain only builtins accessibleto user code.
During pre-execution, each experimental flag determines whether its
builtin is added to
BuiltinModule's user-requirable set viaBuiltinModule.allowRequireByUsers().Before this change,
getAllBuiltinModuleIds()added every scheme-onlybuiltin to the
Module.builtinModulescandidate list, includingexperimental builtins that had not been added to the user-requirable
set.
initializeCJS()then repeated the flag checks and removednode:dtls,node:quic,node:ffi, andnode:vfs.Derive the scheme-only portion of
Module.builtinModulesfrom thealready-established user-requirable set instead. This keeps the list
consistent with the existing
require('node:...')access policy andremoves the duplicated filtering in
initializeCJS().Existing scheme-only builtins such as
node:test,node:sea, andnode:sqliteremain listed.Add coverage for
Module.builtinModulesandrequire('node:...')with and without each experimental flag.
Refs: #56185
Refs: #56870
Refs: #63158