ffi: enable module by default - #65475
Merged
Merged
Conversation
Enable node:ffi by default in builds with FFI support. Keep --experimental-ffi as a compatibility no-op and --no-experimental-ffi as an opt-out. Loading the module still emits an experimental warning. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65475 +/- ##
==========================================
- Coverage 90.13% 90.13% -0.01%
==========================================
Files 751 751
Lines 252405 252405
Branches 47464 47463 -1
==========================================
- Hits 227508 227502 -6
+ Misses 16213 16206 -7
- Partials 8684 8697 +13
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 22, 2026
mcollina
added
the
semver-minor
Member
Author
|
Marking it as semver-minor because it's node:-prefixed. |
mcollina
added
the
notable-change
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
github-actions
Bot
removed
the
request-ci
Collaborator
panva
approved these changes
Aug 23, 2026
atlowChemi
approved these changes
Aug 23, 2026
Collaborator
Collaborator
mcollina
added
the
commit-queue
Collaborator
|
Landed in 9f04fcd |
nodejs-github-bot
removed
the
commit-queue
panva
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
Enable node:ffi by default in builds with FFI support. Keep --experimental-ffi as a compatibility no-op and --no-experimental-ffi as an opt-out. Loading the module still emits an experimental warning. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65475 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
node:ffiby default in builds with FFI support. Keep--experimental-ffias a compatibility no-op and--no-experimental-ffias an opt-out. The module remains experimental and continues to emit a warning when first loaded.