vfs: validate ZipProvider parent directories - #65829
Open
trivikr wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65829 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 771 771
Lines 265485 265509 +24
Branches 50466 50476 +10
=======================================
+ Hits 239381 239416 +35
+ Misses 17043 17030 -13
- Partials 9061 9063 +2
🚀 New features to boost your workflow:
|
Member
Author
|
FYI: @pipobscure |
jasnell
approved these changes
Sep 6, 2026
trivikr
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
commit-queue
nodejs-github-bot
added
lacks-second-approval
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
removed
commit-queue-failed
Member
|
@trivikr ... this will need a rebase. |
Reject attempts to create archive entries beneath non-directory parents. Cover open, mkdir, and rename in the sync and async APIs. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex
trivikr
force-pushed
the
vfs-zip-provider-non-dir-parents
branch
from
September 10, 2026 01:00
4a1f731 to
3670ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65828
Reject attempts to create archive entries beneath non-directory parents. Cover open, mkdir, and rename in the sync and async APIs.
Assisted-by: codex