test: split test-bench-cli to try deflaking it - #65919
Merged
nodejs-github-bot merged 1 commit intoSep 10, 2026
Merged
Conversation
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/deflake-test-bench-cli
branch
from
September 8, 2026 21:05
36ce463 to
7b23fc6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Sep 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65919 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 771 771
Lines 265489 265489
Branches 50471 50467 -4
==========================================
- Hits 239402 239395 -7
- Misses 17013 17049 +36
+ Partials 9074 9045 -29 🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/deflake-test-bench-cli
branch
from
September 9, 2026 01:24
7b23fc6 to
bd25f89
Compare
This comment was marked as outdated.
This comment was marked as outdated.
H4ad
approved these changes
Sep 9, 2026
panva
approved these changes
Sep 9, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
StefanStojanovic
approved these changes
Sep 10, 2026
jasnell
force-pushed
the
jasnell/deflake-test-bench-cli
branch
from
September 10, 2026 14:54
bd25f89 to
886b571
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I believe the test-bench-cli flakes were just because the one file was doing too much and on some architectures was taking too long to complete. This splits up the file. At the very least, if there's still a flake in here, the smaller, more focused files should help narrow it down Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/deflake-test-bench-cli
branch
from
September 10, 2026 15:53
886b571 to
dcbf1f5
Compare
Collaborator
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/77299/ ✔ Build data downloaded ℹ Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/77299/ ✖ Refusing to start a potentially duplicate CI job. Use the "Resume build" button in the Jenkins UI, or start a new CI manually.https://github.com/nodejs/node/actions/runs/34501697431 |
Member
Author
|
Yay the duplicate |
H4ad
approved these changes
Sep 10, 2026
Collaborator
|
Landed in ffc4203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the test-bench-cli flakes were just because the one file was doing too much and on some architectures was taking too long to complete. This splits up the file. At the very least, if there's still a flake in here, the smaller, more focused files should help narrow it down