Skip to content

test: split test-bench-cli to try deflaking it - #65919

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/deflake-test-bench-cli
Sep 10, 2026
Merged

test: split test-bench-cli to try deflaking it#65919
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/deflake-test-bench-cli

Conversation

@jasnell

@jasnell jasnell commented Sep 8, 2026

Copy link
Copy Markdown
Member

I believe the test-bench-cli flakes were just because the one file was doing too much and on some architectures was taking too long to complete. This splits up the file. At the very least, if there's still a flake in here, the smaller, more focused files should help narrow it down

@jasnell
jasnell requested a review from mcollina September 8, 2026 20:35
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 8, 2026

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot

This comment was marked as outdated.

@jasnell
jasnell force-pushed the jasnell/deflake-test-bench-cli branch from 36ce463 to 7b23fc6 Compare September 8, 2026 21:05
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (bb79aca) to head (dcbf1f5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65919      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files         771      771              
  Lines      265489   265489              
  Branches    50471    50467       -4     
==========================================
- Hits       239402   239395       -7     
- Misses      17013    17049      +36     
+ Partials     9074     9045      -29     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
jasnell force-pushed the jasnell/deflake-test-bench-cli branch from 7b23fc6 to bd25f89 Compare September 9, 2026 01:24
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 9, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026
@jasnell
jasnell force-pushed the jasnell/deflake-test-bench-cli branch from bd25f89 to 886b571 Compare September 10, 2026 14:54
@nodejs-github-bot

This comment was marked as outdated.

I believe the test-bench-cli flakes were just because the
one file was doing too much and on some architectures was
taking too long to complete. This splits up the file.
At the very least, if there's still a flake in here, the
smaller, more focused files should help narrow it down

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnell force-pushed the jasnell/deflake-test-bench-cli branch from 886b571 to dcbf1f5 Compare September 10, 2026 15:53
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026
@github-actions github-actions Bot added the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/77299/
✔  Build data downloaded
   ℹ  Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/77299/
   ✖  Refusing to start a potentially duplicate CI job. Use the "Resume build" button in the Jenkins UI, or start a new CI manually.
https://github.com/nodejs/node/actions/runs/34501697431

@jasnell

jasnell commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Yay the duplicate request-ci detection is working!

@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 10, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Sep 10, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ffc4203 into nodejs:main Sep 10, 2026
72 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ffc4203

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants