test: improve sequential test performance - #65928
Open
jasnell wants to merge 1 commit into
Open
Conversation
Make a couple of sequential tests clean up eagerly to reduce runtime. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65928 +/- ##
==========================================
- Coverage 92.40% 90.18% -2.23%
==========================================
Files 417 771 +354
Lines 188989 265451 +76462
Branches 28924 50454 +21530
==========================================
+ Hits 174642 239404 +64762
- Misses 14015 17018 +3003
- Partials 332 9029 +8697 🚀 New features to boost your workflow:
|
Collaborator
lpinca
approved these changes
Sep 9, 2026
| // Family autoselection might be skipped if only a single address is returned by DNS. | ||
| const actualError = Array.isArray(error.errors) ? error.errors[0] : error; | ||
|
|
||
| net.createConnection({ host: common.localhostIPv4, port }).on('error', common.mustCallAtLeast((error) => { |
Member
There was a problem hiding this comment.
Suggested change
| net.createConnection({ host: common.localhostIPv4, port }).on('error', common.mustCallAtLeast((error) => { | |
| net.createConnection({ host: common.localhostIPv4, port }).on('error', common.mustCall((error) => { |
| if (rounds === ROUNDS) return check(); | ||
| rounds++; | ||
| pummel(); | ||
| }, 0)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a couple of sequential tests clean up eagerly to reduce runtime. Potentially saves in the range of 5-12 seconds per run on some CI jobs.