Skip to content

test: try fixing windows build replacing WMIC - #65949

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/try-fixing-windows-ci
Open

test: try fixing windows build replacing WMIC#65949
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/try-fixing-windows-ci

Conversation

@jasnell

@jasnell jasnell commented Sep 10, 2026

Copy link
Copy Markdown
Member

Refs: nodejs/build#4461 (comment)

Trying this to see if it works.

/cc @aduh95

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (fd6682c) to head (c9428b1).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65949      +/-   ##
==========================================
+ Coverage   90.16%   90.18%   +0.02%     
==========================================
  Files         771      771              
  Lines      265445   265485      +40     
  Branches    50455    50471      +16     
==========================================
+ Hits       239329   239419      +90     
+ Misses      17056    17003      -53     
- Partials     9060     9063       +3     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva

panva commented Sep 10, 2026

Copy link
Copy Markdown
Member

I think this is part of a workaround, the rest is touching up the other uses

Refs: nodejs/build#4463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants