test_runner: avoid reusing V8 serializers - #65951
Open
inoway46 wants to merge 1 commit into
Open
Conversation
A serializer must not be used after releaseBuffer() is called. Use a dedicated instance to calculate the header length and create a new serializer for each test event. Add a regression test that serializes the same object twice and verifies that both frames can be deserialized independently. Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
inoway46
marked this pull request as ready for review
September 10, 2026 06:19
inoway46
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65951 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 771 771
Lines 265489 265490 +1
Branches 50471 50469 -2
=======================================
+ Hits 239388 239414 +26
+ Misses 17042 17007 -35
- Partials 9059 9069 +10
🚀 New features to boost your workflow:
|
StefanStojanovic
approved these changes
Sep 10, 2026
StefanStojanovic
added
the
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializer#releaseBuffer()documents that a serializer should not be used after its buffer has been released.This change follows that contract by using a dedicated serializer for the header length and a new serializer for each test event.
This was found while investigating the intermittent Windows crash in the referenced issue and may be its cause.
Refs: #65756