chore(remark-lint): improve for node core#9016
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
Several English MD/MDX pages were updated so existing links pass the new checks (e.g. EOL release schedule path, N-API learn URL, branding link, stale Reviewed by Cursor Bugbot for commit e244251. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
+ Coverage 74.57% 75.11% +0.53%
==========================================
Files 100 102 +2
Lines 8803 9109 +306
Branches 324 372 +48
==========================================
+ Hits 6565 6842 +277
- Misses 2234 2263 +29
Partials 4 4 ☔ View full report in Codecov by Harness. |
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
|
Bump @nodejs/web-infra |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
there's a cursor concern here Link validator lacks needed options that is perhaps valid. can you validate the real runtime scenarios here? it'd be bad if this resulted in false-positivies
|
Replaced
|
Signed-off-by: Aviv Keller <me@aviv.sh>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e244251. Configure here.
| "ignoreFiles": ["pages/!(en)/**/*.{md,mdx}"], | ||
| "ignoreLinks": ["/learn", "/learn/**/*", "/static/**/*", "/feed/*"] | ||
| } | ||
| ] |
There was a problem hiding this comment.
Link ignores never apply
High Severity
validate-links is registered twice with split options: the preset enables it with basePaths but no ignoreFiles/ignoreLinks, while .remarkrc.json adds another instance with only the ignores. Both run, so /learn, /feed, and non-English pages are still flagged by the preset instance, and the remarkrc instance lacks basePaths so valid site routes can fail too.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e244251. Configure here.


Improves the
remark-lintpackage by: