chore: apply Prettier formatting to all files - #1027
Merged
Conversation
Running `node --run format` as part of the nightly update-links workflow produces a dirty diff in `.github/workflows/update-links.yml` (cron quote style) and `scripts/constants.mjs` (array trailing comma). Pre-applying Prettier here means the format step in the nightly workflow produces no further changes and `git-auto-commit-action` has nothing unexpected to push. Refs #1020 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LXvbysVPDnes541gBuD1ia
MattIPv4
approved these changes
Sep 9, 2026
MattIPv4
left a comment
MattIPv4
left a comment
Member
There was a problem hiding this comment.
We should have a CI check for formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly update-links workflow runs
node --run formatbefore committing the directory cache, and the Prettier format script covers**/*.yml. Two files weren't aligned with Prettier's output, so on every rungit-auto-commit-actionpicked them up and tried to push a diff that included.github/workflows/update-links.yml— which GitHub blocks withoutworkflowswrite permission.Pre-applying the Prettier output here means the format step produces no further changes and the auto-commit only ever touches the actual cache files it's meant to update.
Refs #1020