test: stabilize HTTP/2 timeout tests - #5689
Open
mcollina wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5689 +/- ##
==========================================
- Coverage 93.46% 93.46% -0.01%
==========================================
Files 110 110
Lines 38777 38777
==========================================
- Hits 36244 36243 -1
- Misses 2533 2534 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the HTTP/2 churn stress test on Linux Node.js 24 and 25, where nodejs/node#64841 can terminate the process before the test reports an assertion. Keep the test enabled on unaffected platforms and Node.js versions, and release each seed's resources before the next seed runs.
Make the issue #5087 timeout tests own and await their HTTP/2 teardown, cancel delayed server work, and only tolerate the reset errors expected from intentionally timed-out streams. This supersedes #5643 with the additional Node.js 25 and timeout-test fixes.