Remove unused SSL setup from Windows CI - #3911
Merged
Merged
Conversation
Print the PostgreSQL server log when startup fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review tier: Lite
Findings: None
What changed in this PR
Removes obsolete SSL setup from Windows PostgreSQL CI and improves startup failure diagnostics.
Changes:
- Removes certificate copying and SSL startup options.
- Prints PostgreSQL logs when startup fails.
- Propagates startup failures and retains
SSL Mode=Disable.
| File | Summary |
|---|---|
.github/workflows/build.yml |
Updates Windows PostgreSQL startup and failure handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows PostgreSQL startup has been failing consistently in sampled recent runs (example). The likely cause is the EDB package's upgrade from OpenSSL 3.0 to 3.5, whose default security level rejects our 1024-bit test certificate; the actual server error was hidden in an uncollected log file.
Remove the certificate-copy step and SSL startup options, since tests already use
SSL Mode=Disable. Also print the PostgreSQL log and fail the step if startup fails, so future failures expose the underlying error.