Skip to content

feat(i18n): implement danish translations - #2344

Open
luxass wants to merge 26 commits into
npmx-dev:mainfrom
luxass:luxass/add-da-translations
Open

luxass wants to merge 26 commits into
npmx-dev:mainfrom
luxass:luxass/add-da-translations

Conversation

@luxass

@luxass luxass commented Mar 31, 2026

Copy link
Copy Markdown

🧭 Context

This adds danish translations.

Some words stays the same, because we either don't have a word for it, or that it makes better sense to keep it as-is.

  • README -> README

📚 Description

This PR adds danish translations to the list of available translations.

I made use of AI for some of the translation keys, since it made the entire process faster. I manually reviewed the sentences afterwards, by navigating to each page and read the text.

@vercel

vercel Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs.npmx.dev Ready Ready Preview Sep 15, 2026 1:06am UTC
npmx.dev Ready Ready Preview Sep 15, 2026 1:06am UTC
1 Skipped Deployment
Project Deployment Actions Updated
npmx-lunaria Ignored Ignored Sep 15, 2026 1:06am UTC

Request Review

@github-actions

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @luxass! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Comment thread i18n/locales/da-DK.json Outdated
@jhroemer

Copy link
Copy Markdown
Contributor

Nice to see @luxass - I'd be happy to review. But since it's still a draft I'll hold off a bit. Feel free to ping me when you're ready.

@coderabbitai

coderabbitai Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1bd654b0-b7bd-418e-981b-f0fec02fbd40

📥 Commits

Reviewing files that changed from the base of the PR and between bd58095 and f92a85c.

📒 Files selected for processing (1)
  • config/i18n.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • New Features
    • Added Danish language support across the application.
    • Danish translations now cover navigation, search, settings, authentication, package views, accessibility, privacy, and other interface messaging.

Walkthrough

The PR registers Danish as a supported locale and adds the complete da-DK translation catalogue for npmx interface content.

Changes

Danish locale

Layer / File(s) Summary
Register and provide Danish translations
config/i18n.ts, i18n/locales/da-DK.json
The locale configuration adds code da, file da-DK.json, and name Dansk. The catalogue adds Danish translations for supported features, messages, statuses, accessibility, privacy, administration, comparisons, branding, and changelogs.

Suggested reviewers: jhroemer

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 0bba6

Danish users may see incorrect or ungrammatical wording in several interface messages. The PR is otherwise low risk, but these translation issues should be corrected before completion.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly states that the pull request adds Danish translations and registers Danish as an available locale. It also gives relevant context about unchanged terms and translation review.
Title check ✅ Passed The title clearly summarises the main change: adding Danish translations. It is concise, specific, and uses a conventional commit format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luxass
luxass force-pushed the luxass/add-da-translations branch from dbd9e22 to 5711e6c Compare April 13, 2026 15:53
@github-actions github-actions Bot added stale This has become stale and may be closed soon and removed stale This has become stale and may be closed soon labels May 14, 2026
@github-actions github-actions Bot added the stale This has become stale and may be closed soon label Jun 14, 2026
@github-actions github-actions Bot removed the stale This has become stale and may be closed soon label Jun 15, 2026
@ghostdevv

Copy link
Copy Markdown
Member

Hey @luxass, you still interested in working on this? /nf

luxass and others added 25 commits September 12, 2026 06:14
Co-authored-by: Jens Rømer Hesselbjerg <jh.roemer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization needs review This PR is waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants