Skip to content

fix(ci): generate devtools client .nuxt types before typecheck job - #1089

Merged
antfu merged 2 commits into
nuxt:mainfrom
antfubot:fix/typecheck-ci-missing-nuxt-prepare
Sep 10, 2026
Merged

fix(ci): generate devtools client .nuxt types before typecheck job#1089
antfu merged 2 commits into
nuxt:mainfrom
antfubot:fix/typecheck-ci-missing-nuxt-prepare

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

The `typecheck` job runs in a fresh checkout and only restores
`packages//dist` from the `build` job's artifact — it never
regenerates `packages/devtools/client/.nuxt`, so the root
`tsconfig.json`'s `extends` target is missing. `vue-tsc` silently
falls back to default compiler options (dropping `skipLibCheck`),
which then tries to resolve `@nuxt/schema-nightly`'s bundled type
imports (`webpack-
`, h3's renamed `CorsOptions`, etc.) that aren't
otherwise installed — failing the job with unrelated "cannot find
module" errors.

Run `pnpm -C packages/devtools run dev:prepare` (the same lightweight
stub + `nuxi prepare` step the combined job used to get for free)
before `pnpm typecheck` to regenerate the missing `.nuxt` config.


This PR was created with the help of an agent.

antfubot and others added 2 commits September 10, 2026 00:10
The typecheck job runs in its own fresh checkout and only restores
packages/*/dist from the build job's artifact — it never regenerates
packages/devtools/client/.nuxt, so the root tsconfig's `extends` target
is missing. vue-tsc silently falls back to default compiler options,
which drops skipLibCheck and resolves @nuxt/schema-nightly's bundled
type imports (webpack-*, h3's renamed CorsOptions, etc.) that aren't
otherwise installed, failing the job.

Co-authored-by: opencode <noreply@opencode.ai>
The pull_request-triggered autofix.ci workflow duplicates ci.yml's
typecheck job definition and has the identical missing-.nuxt bug —
this is actually the workflow that runs on PRs and was still failing.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1f7bcfe1-76d0-4644-a1ca-10da610111fc

📥 Commits

Reviewing files that changed from the base of the PR and between 7d7e9b4 and 9f80234.

📒 Files selected for processing (2)
  • .github/workflows/autofix.yml
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The CI and autofix workflows now run pnpm -C packages/devtools run dev:prepare in their typecheck jobs. The command runs after the build artifact download and before pnpm typecheck.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9f802

CI and pull-request autofix typechecks now prepare the devtools Nuxt configuration before checking types, preventing fresh-checkout configuration failures without introducing an identified merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: generating the devtools client .nuxt types before the CI typecheck job.
Description check ✅ Passed The description explains the missing .nuxt configuration, the resulting typecheck failures, and the preparation step added to both workflows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antfu
antfu merged commit 1b2c240 into nuxt:main Sep 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants