fix(ci): generate devtools client .nuxt types before typecheck job - #1089
Conversation
The typecheck job runs in its own fresh checkout and only restores packages/*/dist from the build job's artifact — it never regenerates packages/devtools/client/.nuxt, so the root tsconfig's `extends` target is missing. vue-tsc silently falls back to default compiler options, which drops skipLibCheck and resolves @nuxt/schema-nightly's bundled type imports (webpack-*, h3's renamed CorsOptions, etc.) that aren't otherwise installed, failing the job. Co-authored-by: opencode <noreply@opencode.ai>
The pull_request-triggered autofix.ci workflow duplicates ci.yml's typecheck job definition and has the identical missing-.nuxt bug — this is actually the workflow that runs on PRs and was still failing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe CI and autofix workflows now run Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to CI and pull-request autofix typechecks now prepare the devtools Nuxt configuration before checking types, preventing fresh-checkout configuration failures without introducing an identified merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `typecheck` job runs in a fresh checkout and only restores
`packages//dist` from the `build` job's artifact — it never
regenerates `packages/devtools/client/.nuxt`, so the root
`tsconfig.json`'s `extends` target is missing. `vue-tsc` silently
falls back to default compiler options (dropping `skipLibCheck`),
which then tries to resolve `@nuxt/schema-nightly`'s bundled type
imports (`webpack-`, h3's renamed `CorsOptions`, etc.) that aren't
otherwise installed — failing the job with unrelated "cannot find
module" errors.
Run `pnpm -C packages/devtools run dev:prepare` (the same lightweight
stub + `nuxi prepare` step the combined job used to get for free)
before `pnpm typecheck` to regenerate the missing `.nuxt` config.
This PR was created with the help of an agent.