feat: complete typed Funding API - #101
Open
nyg wants to merge 1 commit into
Open
Conversation
Preserve pagination, decimal amounts, unlimited deposit limits, and unsuccessful cancellation results across the ten legacy Funding operations. Refs #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the ten Funding operations from #82 with typed endpoints, parameter builders, response records, and KrakenAPI methods: DepositMethods, DepositAddresses, DepositStatus, WithdrawMethods, WithdrawAddresses, WithdrawInfo, Withdraw, WithdrawStatus, WithdrawCancel, and WalletTransfer. Public library types and methods include Javadoc following the existing code.
Status responses preserve both transaction lists and pagination cursors, accepting the unpaginated array and paginated object formats. Deposit limits distinguish finite amounts, unlimited (
false), and missing values. Monetary fields use BigDecimal, timestamps use long integers, and enums retain unknown-value fallbacks. Requests support asset classes, rebase options, Lightning invoice amounts, address confirmation, maximum withdrawal fees, and explicit wallet names. Cancellation preserves a valid false result.Validation: Java 25
clean packagepasses for both modules; 81 JUnit tests cover all endpoint parameters, documented response fixtures, facade routing, required fields and credentials, pagination, decimal precision, nested fee and limit data, signed request bodies, and Kraken errors. The library Javadoc jar builds withdoclint=all,-missing. Tests use Mockito and AssertJ with no network calls, API keys, withdrawals, or transfers. The Funding and Account Data branches merge cleanly and pass all 173 tests together.This PR targets master independently of Market Data #99 and Account Data #100, using the same test infrastructure. It covers the
/0/privateFunding group from the issue, which Kraken now calls Funding (Legacy); Funding (Beta) is separate. Refs #82; the umbrella issue remains open.