Skip to content

chore(plugin-webhooks): drop the dead sys_webhook_delivery i18n blocks#3492

Merged
os-zhuang merged 1 commit into
mainfrom
claude/hungry-edison-9bcceb
Jul 26, 2026
Merged

chore(plugin-webhooks): drop the dead sys_webhook_delivery i18n blocks#3492
os-zhuang merged 1 commit into
mainfrom
claude/hungry-edison-9bcceb

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What

sys_webhook_delivery was removed from @objectstack/plugin-webhooks when outbound delivery moved to @objectstack/service-messaging (sys_http_delivery, ADR-0018 M3). But its stale i18n translation blocks lingered in all four generated locale bundles — loaded at runtime yet referenced by nothing, since the object no longer exists in this plugin.

Changes

  • Bundles (en / zh-CN / ja-JP / es-ES *.objects.generated.ts): removed the entire sys_webhook_delivery node (−111 lines each). WebhooksTranslations now carries only sys_webhook.
  • scripts/i18n-extract.config.ts: dropped the dangling SysWebhookDelivery import (it pointed at the deleted sys-webhook-delivery.object.js, which broke the documented os i18n extract regeneration command) and the objects-array entry. It now extracts SysWebhook only.
  • src/sys-webhook.object.ts: corrected the stale ownership comment that still named sys_webhook_delivery as a live sibling; it now points at the service-messaging sys_http_delivery migration.

Note: the PR description's premise that the config was "already fixed in #3461" did not hold — #3461 is an open issue (spec WebhookSchema ↔ dispatcher disconnect), not a merged PR, so the config still had the dangling import. That's fixed here, so the header's os i18n extract command resolves cleanly again.

Verification

  • pnpm turbo build --filter=@objectstack/plugin-webhooks --force → green (ESM + CJS + DTS, i.e. a real tsc type-check).
  • Loaded the built ESM bundle: every locale's objects map is exactly ["sys_webhook"]; sys_webhook_delivery absent from the compiled output.
  • pnpm test (vitest) → 14/14 pass.
  • No remaining sys_webhook_delivery / SysWebhookDelivery references in the plugin's src or scripts.

Out of scope (flagged separately)

Two stale doc comments in the platform-objects package (src/integration/index.ts, src/apps/setup.app.ts) still name sys_webhook_delivery as a plugin-webhooks object — left out to keep this change scoped to plugin-webhooks; being handled in a separate cleanup. The service-messaging/http-delivery.object.ts old→new field-mapping note is intentional and untouched.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jul 26, 2026 7:30am

Request Review

`sys_webhook_delivery` was removed from @objectstack/plugin-webhooks when
outbound delivery moved to @objectstack/service-messaging (`sys_http_delivery`,
ADR-0018 M3), but its translation blocks lingered in all four generated locale
bundles — loaded at runtime yet referenced by nothing.

- Removed the `sys_webhook_delivery` node from each *.objects.generated.ts
  bundle (en/zh-CN/ja-JP/es-ES); WebhooksTranslations now carries only
  sys_webhook.
- Corrected the stale ownership comment on SysWebhook that still named
  sys_webhook_delivery as a live sibling.

The dangling SysWebhookDelivery import in scripts/i18n-extract.config.ts was
fixed independently on main by #3489, so it is not part of this change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@xuyushun441-sys
xuyushun441-sys force-pushed the claude/hungry-edison-9bcceb branch from 4d0f2ed to 524e6ea Compare July 26, 2026 07:27
@github-actions github-actions Bot added documentation Improvements or additions to documentation tooling size/m labels Jul 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/plugin-webhooks.

3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:

  • content/docs/automation/webhooks.mdx (via packages/plugins/plugin-webhooks)
  • content/docs/plugins/packages.mdx (via @objectstack/plugin-webhooks)
  • content/docs/releases/implementation-status.mdx (via @objectstack/plugin-webhooks)

Advisory only. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs origin/main → pass the list as args.docs.

@os-zhuang
os-zhuang merged commit c95ac80 into main Jul 26, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/hungry-edison-9bcceb branch July 26, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant