fix(app-shell): built-moment transition fires on auto-publish envelopes too (#5799) - #5921
Merged
Merged
Conversation
…es too (#5799) Staging verification caught it: the transition keyed on draftReview, which only lifts status:'drafted' -- but an auto-publish environment (staging/cloud posture) rewrites the whole-app build envelope to status:'published' (keeping drafted[] + packageId), so reopening a built conversation stayed on the full page. detectBuiltAppPackage reads the raw envelope, posture-independent; new pin drives the published shape through the real page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging verification of #5865 caught the gap: the transition keyed on
draftReview(drafted-only), but auto-publish environments — the staging/cloud posture — rewrite the whole-app envelope tostatus:'published'(keepingdrafted[]+packageId), so reopening a built conversation stayed on the full page.detectBuiltAppPackagereads the raw envelope for either status; new pin drives the published shape end-to-end. 5/5 transition pins + chatbot suites green.🤖 Generated with Claude Code