docs: bring CURRENT_STATE forward after #161 and fix the stale ID allocation - #165
Merged
Merged
Conversation
…ocation The station ID allocation claimed 017 was reserved for #108. It was not: refused-authorization.ts took CS-SYNTHETIC-017 when it shipped in 0.4.5, after that line was written, so anyone following #108 would have created the same collision #133 did. #108 now reserves 021, and the line records live allocation with the next free number. Corrects rule coverage from two uncovered rules to one, verified by iterating the registry rather than by reading: 15 of the 16 codes appear in some scenario's expectedFailures and REPEATED_BOOT_NOTIFICATION is the only gap. Corrects the corpus arithmetic from 17 to 19. Records this week: #161 merged as the third external contributor's first merge, both remaining scenario issues assigned, the #108 trap caught before the contributor started, #163 opened for the assertions-coverage gap, and the release automation from #152 handling 0.4.5 unattended. Closes #164
sepehr-safari
added
type:docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164.
Brings the narrative half of
CURRENT_STATE.mdforward after #161. The automatedhalf needed nothing: #152 logged
0.4.5and moved the Package Status Table on itsown, which is the split working as designed.
The one that mattered
The station ID allocation line claimed
017was reserved for #108. It was not.refused-authorization.ts:8tookCS-SYNTHETIC-017when it shipped in0.4.5,after that line was written, so anyone picking up #108 would have created exactly
the collision #133 did. #108 now reserves
CS-SYNTHETIC-021, and the line recordslive allocation plus the next free number so the next reservation does not have to
re-derive it.
Corrections
registry rather than by reading, 15 of the 16 codes appear in some scenario's
expectedFailures, andREPEATED_BOOT_NOTIFICATION(Add a new scenario: repeated-boot-notification #139) is the only gap.once Add a new scenario: meter-value-zero #108 and Add a new scenario: repeated-boot-notification #139 land.
Added
#161 merged as the third external contributor's first merge, both remaining
scenario issues assigned, the #108 trap caught before the contributor started, and
#163 opened for the assertions-coverage gap found while reviewing #161.
Verification
Confirmed my edits did not break the automation that parses this file: the script
still finds its markers and the table row, still no-ops at
0.4.5withoutduplicating the entry, and its 9 unit tests pass.
pnpm format:checkandpnpm lintpass. Every version, count, issue state and station ID owner in thediff was checked against the tree and GitHub rather than carried from memory.
Documentation only, no changeset: the file is not in the package
fileslist.