Skip to content

Panic on copy length mismatch #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szymon-zadworny merged 1 commit into from
Aug 6, 2026
Merged

Panic on copy length mismatch #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions oneapi-rs/src/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
// SPDX-License-Identifier: MIT OR Apache-2.0
//

use std::cmp::min;

use bytemuck::Pod;
use oneapi_rs_sys::{queue::ffi, types::ffi::EventPtr};

Expand Down Expand Up @@ -159,8 +157,7 @@ impl Queue {

/// Copies the contents of the source buffer to the destination buffer.
///
/// If the buffer sizes don't match the destination buffer is filled with as many elements from
/// source buffer as possible.
/// Panics if the source and destination buffer lengths differ.
pub fn copy<T, A1, A2>(&mut self, src: &Buffer<T, A1>, dst: &mut Buffer<T, A2>) -> Event
where
T: Pod,
Expand All @@ -173,8 +170,7 @@ impl Queue {
/// Copies the contents of the source buffer to the destination buffer after all specified
/// events finish.
///
/// If the buffer sizes don't match the destination buffer is filled with as many elements from
/// source buffer as possible.
/// Panics if the source and destination buffer lengths differ.
pub fn copy_with_deps<T, A1, A2>(
&mut self,
src: &Buffer<T, A1>,
Expand All @@ -186,6 +182,12 @@ impl Queue {
A1: UsmAlloc,
A2: UsmAlloc,
{
assert_eq!(
src.get_len(),
dst.get_len(),
"source and destination buffer lengths differ"
);

// TODO: Resolve the C++ lifetime elision issue
let dep_events = dep_events
.iter()
Expand All @@ -194,8 +196,7 @@ impl Queue {
})
.collect::<Vec<_>>();

let amount = min(src.get_len(), dst.get_len());
let num_bytes = amount * size_of::<T>();
let num_bytes = src.get_len() * size_of::<T>();
unsafe {
ffi::memcpy(
&mut self.0,
Expand Down