[BUG] Keep the curl retry deadline stable within an attempt - #4452
Open
shixi-li wants to merge 2 commits into
Open
[BUG] Keep the curl retry deadline stable within an attempt#4452shixi-li wants to merge 2 commits into
shixi-li wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
+ Coverage 82.63% 82.85% +0.23%
==========================================
Files 512 512
Lines 20138 20145 +7
==========================================
+ Hits 16639 16690 +51
+ Misses 3499 3455 -44
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4403
NextRetryTime()drew a new jitter sample on every call, so polling the same retryable request moved its deadline and biased the realized delay toward the lower end of the backoff band.Changes
Responseevent and reuse it for schedulingRetry-Afterdeadlines and use one stable jittered backoff when the header is missing or invalidFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changesTests
curl_http_testsuite./ci/do_ci.sh cmake.maintainer.sync.test./ci/do_ci.sh cmake.test./ci/do_ci.sh cmake.exporter.otprotocol.test./ci/do_ci.sh formatmarkdownlint .Coverage notes
The focused cases exercise the shared completion path through synchronous
Send(). The existing full client suites cover async operation, but this change does not add an end-to-end timing assertion for the pending retry queue. Existing HTTP-date and over-max-backoffRetry-Afterbehavior is unchanged. Local runtime validation was on Linux/amd64.