Skip to content

ci: add shared security scanning workflow - #4465

Open
opentelemetrybot wants to merge 4 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/cpp-tools-20260820
Open

ci: add shared security scanning workflow#4465
opentelemetrybot wants to merge 4 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/cpp-tools-20260820

Conversation

@opentelemetrybot

Copy link
Copy Markdown
Contributor

Tracked in open-telemetry/sig-security#293.

Adds zizmor scanning through the OpenTelemetry shared workflow.

The workflow:

  • runs the regular persona on pull requests, pushes to main, and a randomized weekly schedule;
  • uploads results to GitHub code scanning;
  • uses the shared workflow pinned to an immutable commit.

After merge

  1. Confirm the Zizmor workflow succeeds on the merged default-branch commit and its code-scanning analysis has no findings.
  2. Mark the corresponding admin PR ready for review and merge it to require zizmor code scanning.
  3. On the next repository pull request, confirm GitHub reports a required zizmor code-scanning result.

If enforcement unexpectedly blocks a valid change, restore require_zizmor = false in open-telemetry/admin while leaving scanning enabled.

Add persist-credentials: false to checkout steps, set Dependabot cooldown,
move step outputs into env instead of expanding them into run blocks, and
replace the CMD shell with pwsh.
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a shared, SHA-pinned Zizmor security scanning workflow and hardens GitHub Actions security practices.

Changes:

  • Adds scheduled, PR, push, and manual Zizmor scanning with SARIF upload.
  • Disables persisted checkout credentials across workflows.
  • Hardens shell handling and adds Dependabot cooldowns.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Summary
.github/workflows/zizmor.yml Adds shared Zizmor scanning.
.github/workflows/iwyu.yml Disables checkout credential persistence.
.github/workflows/fossa.yml Disables checkout credential persistence.
.github/workflows/doxygen-tidy.yaml Disables checkout credential persistence.
.github/workflows/dependencies_image.yml Disables checkout credential persistence.
.github/workflows/cppcheck.yml Disables checkout credential persistence.
.github/workflows/codeql-analysis.yml Disables checkout credential persistence.
.github/workflows/cmake_install.yml Disables checkout credential persistence.
.github/workflows/clang-tidy.yaml Hardens environment variable handling.
.github/workflows/ci.yml Disables checkout credentials and updates DocFX shell handling.
.github/workflows/benchmark.yml Disables checkout credential persistence.
.github/dependabot.yml Adds seven-day update cooldowns.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@opentelemetrybot
opentelemetrybot marked this pull request as ready for review August 21, 2026 03:43
@opentelemetrybot
opentelemetrybot requested a review from a team as a code owner August 21, 2026 03:43
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (68a575f) to head (3d978cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4465      +/-   ##
==========================================
+ Coverage   82.62%   82.63%   +0.01%     
==========================================
  Files         512      512              
  Lines       20139    20139              
==========================================
+ Hits        16638    16640       +2     
+ Misses       3501     3499       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants