Fix StringEncoder javadoc Java version and Android condition - #8711
Open
thswlsqls wants to merge 1 commit into
Open
Fix StringEncoder javadoc Java version and Android condition#8711thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-10 01:36 UTC Review the latest changes. Non-blocking check failure: codecov/patch Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8711 +/- ##
=========================================
Coverage 91.65% 91.65%
Complexity 10352 10352
=========================================
Files 1003 1003
Lines 27210 27210
Branches 3199 3199
=========================================
Hits 24939 24939
Misses 1566 1566
Partials 705 705 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8709
Description
UnsafeStringEncodera "Java 8+" implementation, butcreateIfAvailable()needs theString.value(byte[]) andString.coderfields, which Java 8 does not have, so Java 8 always falls back. The inline comment on thecoderlookup already says "this only exists in Java 9+".createUnsafeEncoder(), but the bullet still listed only the Java version condition. Added it to the same sentence.UnsafeStringEncoderjavadoc and theStringEncoderHolderlog message.Testing done
Level.FINElog message; no behavior or API change../gradlew :exporters:common:checkpassed — 70 tests (61test, 8testSenderProvider, 1testWithoutUnsafe), 0 failures.io.opentelemetry.exporter.internal.*.