Skip to content

tox: remove google-genai tox environments - #4957

Merged
aabmass merged 1 commit into
open-telemetry:mainfrom
xrmx:remove-google-genai-instrumentations-from-tox
Aug 25, 2026
Merged

tox: remove google-genai tox environments#4957
aabmass merged 1 commit into
open-telemetry:mainfrom
xrmx:remove-google-genai-instrumentations-from-tox

Conversation

@xrmx

@xrmx xrmx commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

Since the package has been moved to python-genai we can spare some CI jobs. It ain't much, but it's honest work.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Since the package has been moved to python genai we can spare some CI
jobs. It ain't much, but it's honest work.
@xrmx
xrmx requested a review from a team as a code owner August 14, 2026 13:32
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 14, 2026
@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Aug 14, 2026
@xrmx xrmx changed the title tox: remove google-genai tox environemnt tox: remove google-genai tox environments Aug 14, 2026
@xrmx

xrmx commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@lmolkova @aabmass WDYT?

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 14, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-25 21:20 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@aabmass aabmass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this one is fully moved to the new repo and I don't think we will be releasing google-genai from this repo again

@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Approved PRs in Python PR digest Aug 14, 2026
@aabmass

aabmass commented Aug 14, 2026

Copy link
Copy Markdown
Member

I wonder if we can just delete this code altogether tbh. I don't remember why we didn't yet. There is a note in the README about security patching. But I imagine we would just do patch releases off the old branch and not main

Versions ``1.0b0`` and later come from that repository; the copy here only
receives security patches. Upgrade with:

@opentelemetry-pr-dashboard

This comment has been minimized.

@aabmass

aabmass commented Aug 24, 2026

Copy link
Copy Markdown
Member

I wonder if we can just delete this code altogether tbh. I don't remember why we didn't yet. There is a note in the README about security patching. But I imagine we would just do patch releases off the old branch and not main

@xrmx chatted with folks offline and we agreed to just delete. Do you want me to send a separate PR for this, or just update this one?

@aabmass aabmass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking for now to discuss

@github-project-automation github-project-automation Bot moved this from Approved PRs to Reviewed PRs that need fixes in Python PR digest Aug 24, 2026
@aabmass
aabmass dismissed their stale review August 25, 2026 16:39

Unblocking my comment

@aabmass

aabmass commented Aug 25, 2026

Copy link
Copy Markdown
Member

Given the CI crunch let's just merge this. I'll send a follow up PR to delete everythhing else

@aabmass
aabmass added this pull request to the merge queue Aug 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 25, 2026
@aabmass
aabmass added this pull request to the merge queue Aug 25, 2026
@aabmass aabmass moved this from Reviewed PRs that need fixes to Ready for merge in Python PR digest Aug 25, 2026
Merged via the queue into open-telemetry:main with commit bf66187 Aug 25, 2026
775 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for merge to Done in Python PR digest Aug 25, 2026
@xrmx

xrmx commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Given the CI crunch let's just merge this. I'll send a follow up PR to delete everythhing else

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants