Bump maximum admissible version of aio-pika - #4998
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-02 20:51 UTC Review the latest changes. Status above doesn't look right?
|
aio-pika [version 10.0.1][1] was released on July 9th. However, the current auto-instrumentaiton checks for version < 10.0.0. After verifying that the auto-instrumentation works fine with 10.0.1, this commit proposes to bump the maximum admissible version to 11.0.0. [1]: https://github.com/mosquito/aio-pika/releases/tag/10.0.1
a424305 to
63d2df9
Compare
aa0e535 to
78e93f6
Compare
78e93f6 to
bd4b7f8
Compare
|
/dashboard route:reviewers |
|
@haudren-woven, this pull request was routed to reviewers. |
emdneto
left a comment
There was a problem hiding this comment.
Can you run tox -e generate-workflows and update the CI to include the new tox environment? Thanks!
I'm fine with this change, but I believe would be better to test only the oldest/latest supported versions, simmilar to https://github.com/open-telemetry/opentelemetry-python-contrib/blob/c89544601e28422a74daa19e279a99c2cf002d83/instrumentation/opentelemetry-instrumentation-fastapi/test-requirements.latest.txt
|
@emdneto : Sorry for the late reply. I have addressed your change: I created a |
Description
aio-pika version 10.0.1 was released on July 9th. However, the current auto-instrumentaiton checks for version < 10.0.0. After verifying that the auto-instrumentation works fine with 10.0.1, this commit proposes to bump the maximum admissible version to 11.0.0.
I am not entirely sure how unit tests are ran, so I did not add any, but
Fixes # NO-ISSUE
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.