Skip to content

Bump maximum admissible version of aio-pika - #4998

Open
haudren-woven wants to merge 7 commits into
open-telemetry:mainfrom
haudren-woven:fix/bump-aio-pika-max-version
Open

Bump maximum admissible version of aio-pika#4998
haudren-woven wants to merge 7 commits into
open-telemetry:mainfrom
haudren-woven:fix/bump-aio-pika-max-version

Conversation

@haudren-woven

@haudren-woven haudren-woven commented Aug 26, 2026

Copy link
Copy Markdown

Description

aio-pika version 10.0.1 was released on July 9th. However, the current auto-instrumentaiton checks for version < 10.0.0. After verifying that the auto-instrumentation works fine with 10.0.1, this commit proposes to bump the maximum admissible version to 11.0.0.

I am not entirely sure how unit tests are ran, so I did not add any, but

Fixes # NO-ISSUE

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran a test with latest aio-pika and this instrumentation, ensured that traces were being published

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 26, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 26, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-09-02 20:51 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

aio-pika [version 10.0.1][1] was released on July 9th. However, the current auto-instrumentaiton checks for version < 10.0.0. After verifying that the auto-instrumentation works fine with 10.0.1, this commit proposes to bump the maximum admissible version to 11.0.0.

[1]: https://github.com/mosquito/aio-pika/releases/tag/10.0.1
@haudren-woven
haudren-woven force-pushed the fix/bump-aio-pika-max-version branch from a424305 to 63d2df9 Compare August 27, 2026 08:37
@haudren-woven
haudren-woven requested a review from a team as a code owner August 27, 2026 08:37
@haudren-woven
haudren-woven force-pushed the fix/bump-aio-pika-max-version branch 2 times, most recently from aa0e535 to 78e93f6 Compare August 27, 2026 08:42
@haudren-woven
haudren-woven force-pushed the fix/bump-aio-pika-max-version branch from 78e93f6 to bd4b7f8 Compare August 27, 2026 08:44
@haudren-woven

Copy link
Copy Markdown
Author

/dashboard route:reviewers

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

@haudren-woven, this pull request was routed to reviewers.

@emdneto emdneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run tox -e generate-workflows and update the CI to include the new tox environment? Thanks!

I'm fine with this change, but I believe would be better to test only the oldest/latest supported versions, simmilar to https://github.com/open-telemetry/opentelemetry-python-contrib/blob/c89544601e28422a74daa19e279a99c2cf002d83/instrumentation/opentelemetry-instrumentation-fastapi/test-requirements.latest.txt

@github-project-automation github-project-automation Bot moved this to Reviewed PRs that need fixes in Python PR digest Aug 27, 2026
@haudren-woven

Copy link
Copy Markdown
Author

@emdneto : Sorry for the late reply. I have addressed your change: I created a requirements.in, which can get the latest aio-pika and be used for future updates using uv pip compile. I haven't touched the existing test environments. Furthermore, note that the latest aio-pika is not compatible with python <3.11, so I've enabled the latest test only for Python 3.12+. Thanks 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reviewed PRs that need fixes

Development

Successfully merging this pull request may close these issues.

2 participants