fix!: align with the spec for metrics sdk and metrics otlp exporter - #2301
fix!: align with the spec for metrics sdk and metrics otlp exporter#2301xuan-cao-swi wants to merge 6 commits into
Conversation
mwear
left a comment
There was a problem hiding this comment.
lgtm, but there are some rubocop failures that need to be addressed.
|
Not sure if related directly to this change, but shouldn't we synchronize shutdown with the export mutex or re-check |
kaylareopelle
left a comment
There was a problem hiding this comment.
This looks good to me! Do we want any tests to make sure we don't drift away from these changes?
That's a good question, @simi. It might be a separate change to think through. If I'm understanding your question, we don't synchronize shutdown checks in our other exporters. The main OTLP (Traces) exporter doesn't use a mutex at all. I think we should look into this more. If we find a solution, it should be applied to traces, metrics, and logs. |
Description