Skip to content

fix: run actionlint from the OCE fork with corrected action metadata #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kojiromike merged 2 commits into from
Sep 2, 2026
Merged

fix: run actionlint from the OCE fork with corrected action metadata #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987102a
fix: run actionlint from the OCE fork with corrected action metadata
kojiromike Sep 1, 2026
5b6422a
fix: use the canonical client-id input for create-github-app-token
kojiromike Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .github/actionlint.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/actionlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ jobs:
uses: actions/checkout@v7

- name: Run actionlint
uses: rhysd/actionlint@v1.7.12
uses: openCoreEMR/actionlint@v1.7.12-oce.1
4 changes: 2 additions & 2 deletions .github/workflows/php-composer-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ on:
default: ubuntu-latest
secrets:
app-id:
description: GitHub App ID for private-repos auth
description: GitHub App Client ID for private-repos auth
required: false
app-private-key:
description: GitHub App private key for private-repos auth
Expand All @@ -111,7 +111,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v3
with:
app-id: ${{ secrets.app-id }}
client-id: ${{ secrets.app-id }}
private-key: ${{ secrets.app-private-key }}
owner: ${{ github.repository_owner }}
repositories: ${{ inputs.private-repos }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v3
with:
app-id: ${{ secrets.app-id }}
client-id: ${{ secrets.app-id }}
private-key: ${{ secrets.app-private-key }}
owner: ${{ github.repository_owner }}
repositories: ${{ inputs.private-repos }}
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/release-please-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,6 @@ jobs:
if: ${{ env.APP_CLIENT_ID != '' && env.APP_PRIVATE_KEY != '' }}
uses: actions/create-github-app-token@v3
with:
# The credential is a Client ID, so it belongs in `client-id`.
# `app-id` still accepts one but the action now warns on it at
# runtime, on every release across the org. actionlint's bundled
# action database predates the rename and rejects `client-id`, so
# `.github/actionlint.yaml` suppresses those two messages for this
# file alone. Drop that suppression when actionlint ships the new
# input set.
client-id: ${{ env.APP_CLIENT_ID }}
private-key: ${{ env.APP_PRIVATE_KEY }}

Expand Down