Custom hierarchies – other API concept, for now without extended meshes and particles path - #1881
Open
franzpoeschel wants to merge 94 commits into
Open
Custom hierarchies – other API concept, for now without extended meshes and particles path #1881franzpoeschel wants to merge 94 commits into
franzpoeschel wants to merge 94 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } // namespace | ||
|
|
||
| std::future<void> AbstractIOHandlerImpl::flush(FlushLevel l) |
| // method might be called as const. shared_ptr<>s implement interior | ||
| // mutability, so use that here. | ||
|
|
||
| // auto &container_front = container.container_front(); |
| { | ||
| setDirty(false); | ||
| } | ||
| // customHierarchies().printRecursively(); |
| std::to_string(count_of_erased_elements) + " instead."); | ||
| } | ||
|
|
||
| // std::cout << "REWIRED '" << myPath().openPMDPath() << "'." << std::endl; |
| if (res.first->first == RecordComponent::SCALAR) | ||
| { | ||
| this->container().erase(res.first); | ||
| // this->container().erase(res.first); |
| read_nonexistent_attribute::read_nonexistent_attribute(); | ||
| } | ||
|
|
||
| TEST_CASE("custom_hierarchy", "[core]") |
franzpoeschel
force-pushed
the
custom-hierarchies
branch
3 times, most recently
from
May 20, 2026 12:27
036bd34 to
96307f3
Compare
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
June 10, 2026 08:45
233aab3 to
6bd551d
Compare
| #endif | ||
| } | ||
|
|
||
| TEST_CASE("append_mode", "[serial]") |
| #endif | ||
| } | ||
|
|
||
| TEST_CASE("append_mode", "[serial]") |
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
July 8, 2026 08:17
6bd551d to
3922027
Compare
franzpoeschel
force-pushed
the
custom-hierarchies
branch
2 times, most recently
from
July 20, 2026 13:11
9584ceb to
855ff65
Compare
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
August 19, 2026 15:16
3658077 to
08a1fb6
Compare
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
August 24, 2026 09:58
cc51fa4 to
13cee7f
Compare
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
August 27, 2026 08:37
e626d46 to
719b998
Compare
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This makes it easier to keep MPI processes in sync
These were unnecessary, but they snuck WRITE_ATT tasks into the skeleton flush.
not so great, but lets keep that for now
This reverts commit 6a5c9f5.
Maybe remove DeferredInitPolicy over it
* Export new visitHierarchy virtuals from DLL The CoreTests link failed on Windows for the virtual functions introduced by the custom-hierarchies refactor (Attributable/Series/CustomHierarchy::visitHierarchyImpl and Container<...>::flush). Mark them OPENPMDAPI_EXPORT and dllexport the explicit Container instantiations so they are exported from openPMD.dll independent of CMake's WINDOWS_EXPORT_ALL_SYMBOLS (.def) generation, which missed them. * Make Container::flush non-virtual Container<T,T_key,T_container>::flush is only ever called on concrete container types inside the library, never through a Container base pointer/reference. Removing virtual dispatch means the container vtables no longer reference flush, which eliminates the remaining Windows DLL-export requirements for the new CoreTests custom_hierarchy binary. Keep the derived flush() members (BaseRecord, ParticleSpecies, CustomHierarchy) as plain member functions. * Revert Container.cpp changes --------- Co-authored-by: Blablador <noreply@blablador.localhost>
needed for attributes
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
August 27, 2026 10:07
719b998 to
05c3ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tbd
TODO:
Diff: franzpoeschel/openPMD-api@fix-parallel-hdf5...custom-hierarchies