fix(sandbox): preserve falsey instrumentation instances - #4304
Closed
adityasingh2400 wants to merge 1 commit into
Closed
fix(sandbox): preserve falsey instrumentation instances#4304adityasingh2400 wants to merge 1 commit into
adityasingh2400 wants to merge 1 commit into
Conversation
Member
|
As I mentioned at #4299 (review), we no longer accept the similar changes. |
Contributor
Author
|
Understood, and sorry for the noise. I had not seen your note on #4299 when this went up. Holding off on this class entirely until your detection lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sandbox sessions defaulted their instrumentation with
instrumentation or Instrumentation(), so a caller-supplied instance that is falsey was silently discarded and replaced with a fresh default.Instrumentationis a public constructor parameter on every sandbox session and is exported fromagents.sandbox.session, so a subclass that defines__bool__is a supported input.This applies the same treatment #4286 and #4299 used for the realtime model and the compaction decision hooks, extending it to the ten remaining sites.
Test plan
New test in
tests/sandbox/test_session_sinks.pyconstructing aSandboxSessionwith a falseyInstrumentationsubclass and asserting the instance is preserved. It fails onmainbecause a different object is substituted.make lintis clean.make typecheckwas not run to completion locally, though the change preserves the declared type.